-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Extraction of matrix_cell_count is wrong (#3097) #3101
Fix: Extraction of matrix_cell_count is wrong (#3097) #3101
Conversation
7d0fea1
to
0cbfd6b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3101 +/- ##
========================================
Coverage 82.50% 82.50%
========================================
Files 115 115
Lines 12279 12279
========================================
Hits 10131 10131
Misses 2148 2148
Continue to review full report at Codecov.
|
0cbfd6b
to
1238ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approved!
'matrix_cell_count': getattr(file, 'matrix_cell_count', None), | ||
**( | ||
{ | ||
'matrix_cell_count': file.matrix_cell_count, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comma necessary?
1238ea0
to
ef70332
Compare
ef70332
to
e408e18
Compare
No failures after reindexing sandbox. |
Author
Author (reindex)
r
tag to commit title or this PR does not require reindexingreindex
label to PR or this PR does not require reindexingAuthor (freebies & chains)
chain
label to the blocking PR or this PR is not chained to another PRAuthor (upgrading)
u
tag to commit title or this PR does not require upgradingupgrade
label to PR or this PR does not require upgradingAuthor (requirements, before every review)
make requirements_update
or this PR leaves requirements*.txt, common.mk and Makefile untouchedR
tag to commit title or this PR leaves requirements*.txt untouchedreqs
label to PR or this PR leaves requirements*.txt untouchedAuthor (before every review)
make integration_test
passes in personal deployment or this PR does not touch functionality that could break the ITdevelop
, squashed old fixupsPrimary reviewer (after approval)
no demo
no sandbox
Operator (before pushing merge the commit)
reindex
label andr
commit title tagno demo
no sandbox
sandbox
label or PR is labeledno sandbox
sandbox
or this PR does not require reindexingsandbox
sandbox
or this PR does not require reindexingsandbox
Operator (after pushing the merge commit)
N reviews
labelling is accurateOperator (reindex)
dev
or this PR does not require reindexing or does not targetdev
dev
or this PR does not require reindexing or does not targetdev
prod
or this PR does not require reindexing or does not targetprod
prod
or this PR does not require reindexing or does not targetprod
Operator